Original commit message

ChangeScribe message

Add default connect and read timeouts for HttpUrlConnection.

BUG - FEATURE: <type-ID>


This is an object creation modifier commit: this change set is composed of factory, constructor, copy constructor and destructor methods, and these methods allow the creation of objects. This change set is mainly composed of:


1. Changes to package retrofit.client:


1.1. Modifications to ApacheClient.java:


1.1.1. Modify constructor invocation this(new DefaultHttpClient()); at ApacheClient() method

1.1.2. Add a private functionality to create default client


The added/removed methods triggered changes to ApacheClient class


1.2. Add a class for defaults


Referenced by:

Defaults class

ApacheClient class

OkClient class

UrlConnectionClient class


1.3. Modifications to OkClient.java:


1.3.1. Add variable declaration statement at openConnection(Request) method

1.3.2. Add method invocation to method setConnectTimeout of connection object at openConnection(Request) method

1.3.3. Add method invocation to method setReadTimeout of connection object at openConnection(Request) method

1.3.4. Add return statement at openConnection(Request) method

1.3.5. Remove return statement at openConnection(Request) method


1.4. Modifications to UrlConnectionClient.java:


1.4.1. Add variable declaration statement at openConnection(Request) method

1.4.2. Add method invocation to method setConnectTimeout of connection object at openConnection(Request) method

1.4.3. Add method invocation to method setReadTimeout of connection object at openConnection(Request) method

1.4.4. Add return statement at openConnection(Request) method

1.4.5. Remove return statement at openConnection(Request) method